Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add the ability to exemptRepoOrgMembers. #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vitropy
Copy link

@vitropy vitropy commented Aug 6, 2024

The new exemptRepoOrgMembers input to the GitHub Action for this Contributor Assistant automatically "allowlists" members of a repository's GitHub Organization, enabling those GitHub committers to bypass the requirement to sign the organization's CLA document when they are committers on a Pull Request that would otherwise require them to be signatories for their contribution.

This implementation is similar to and may provide guidance for implementing feature request #100, but works for Organizations instead of individual Teams.

The new `exemptRepoOrgMembers` input to the GitHub Action for this
Contributor Assistant automatically "allowlists" members of a
repository's GitHub Organization, enabling those GitHub committers to
bypass the requirement to sign the organization's CLA document when they
are committers on a Pull Request that would otherwise require them to be
signatories for their contribution.

Co-authored-by: Zach Mandeville <zach@entropy.xyz>
@ibakshay
Copy link
Member

@vitropy, Thank you very much for the PR! I really appreciate it. This is a much needed feature.
I have tested your PR and I am getting this following error.
image
Could you please have a look? Am I missing something?
link to the failed workflow - https://github.com/ibakshay/test-github-action-cla/actions/runs/10904429720/job/30260836764?pr=227

@vitropy
Copy link
Author

vitropy commented Sep 17, 2024

Am I missing something?

The error pictured is because you are testing this in a repository belonging to an individual and not an Organization.

@ibakshay
Copy link
Member

I am getting the below error when I tested from a Repository that is belonging to a GitHub Rrganization.

graphql call to get the committers details failed: GraphqlError: Resource not accessible by integration

link to the failed workflow .
Could you please have a look?
@vitropy

@vitropy
Copy link
Author

vitropy commented Sep 20, 2024

A "resource not accessible by integration" error indicates lack of access privileges for your GitHub Action. Increase the access permissions granted to the token you use with your GitHub Action.

I'm sorry, @ibakshay, but I do not have the time to help further. I hope you are able to take the code we offered freely and make use of it. Have a lovely weekend.

@ibakshay
Copy link
Member

A "resource not accessible by integration" error indicates lack of access privileges for your GitHub Action. Increase the access permissions granted to the token you use with your GitHub Action.

I'm sorry, @ibakshay, but I do not have the time to help further. I hope you are able to take the code we offered freely and make use of it. Have a lovely weekend.

no problem. Ideally, I don't want to increase the permission of the default Github Action token.
Thank you for your contribution. I will dig your PR deeper when I am free.

Tropicao added a commit to bootlin/training-materials that referenced this pull request Oct 29, 2024
People from Bootlin do not need to sign the CAA when submitting updates
to the training materials through Github.

This list should be replaced with an exemptRepoOrgMembers flag once the
corresponding feature is merged in CLA Assistant Lite (see [1]) to avoid
having to maintain this user list.

[1] contributor-assistant/github-action#157

Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants