Make health checking opt-in

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
controlplaneio-fluxcd · Jan 8, 2025 · d85159e · d85159e
1 parent bd3accb
commit d85159e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/api/v1/resourceset_types.go b/api/v1/resourceset_types.go
@@ -43,9 +43,8 @@ type ResourceSetSpec struct {
 	// +optional
 	ServiceAccountName string `json:"serviceAccountName,omitempty"`
 
-	// Wait instructs the controller to check the health of all the reconciled
-	// resources. Defaults to true.
-	// +kubebuilder:default:=true
+	// Wait instructs the controller to check the health
+	// of all the reconciled resources.
 	// +optional
 	Wait bool `json:"wait,omitempty"`
 }

diff --git a/config/crd/bases/fluxcd.controlplane.io_resourcesets.yaml b/config/crd/bases/fluxcd.controlplane.io_resourcesets.yaml
@@ -123,10 +123,9 @@ spec:
                   when reconciling the generated resources.
                 type: string
               wait:
-                default: true
                 description: |-
-                  Wait instructs the controller to check the health of all the reconciled
-                  resources. Defaults to true.
+                  Wait instructs the controller to check the health
+                  of all the reconciled resources.
                 type: boolean
             type: object
           status:

diff --git a/docs/api/v1/resourceset.md b/docs/api/v1/resourceset.md
@@ -445,7 +445,7 @@ The reconciliation of behaviour of a ResourceSet can be configured using the fol
 
 The `.spec.wait` field is optional and instructs the flux-operator to perform
 a health check on all applied resources and waits for them to become ready. The health
-check is enabled by default and can be disabled by setting the `.spec.wait` field to `false`.
+check is disabled by default and can be enabled by setting the `.spec.wait` field to `true`.
 
 The health check is performed for the following resources types: