Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FluxInstance artifact reconciler #127

Merged
merged 14 commits into from
Dec 18, 2024
Merged

Add FluxInstance artifact reconciler #127

merged 14 commits into from
Dec 18, 2024

Conversation

matheuscscp
Copy link
Member

@matheuscscp matheuscscp commented Dec 17, 2024 •
edited
Loading

Closes: #121

@matheuscscp
Add FluxInstance artifact reconciler
07f0e35 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Copy link
Member Author

Will investigate the e2e timeout tomorrow.

@matheuscscp
Remove unneeded annotation from olm example
b57dadd 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Fix skip condition for artifact not specified to avoid race condition
40f6f85 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Change watch configuration for artifact reconciler
677fe8f 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Fix controller crashloopbackoff
8fe85a0 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Change reconciler name to fluxinstance_artifact
3bcaa76 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Requeue after interval when last artifact revision is missing
041465e 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Skip reconciliation when object is not ready
e5d07de 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Change spamming log from info to debug level
43b9dc1 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Change log message to make it different from the one printed by the m…
cb4fded 
…ain reconciler

Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Add missing plural to log message
df2e485 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Use crane.Digest instead of crane.Head to fetch artifact digest
28eb4ae 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Remove reconcileArtifactEvery annotation in example without artifact
3e319a1 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
@matheuscscp
Adjust artifact reconciliation predicate
704802f 
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
stefanprodan
stefanprodan approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @matheuscscp 🥇

@stefanprodan stefanprodan added the area/update-automation Flux update automation related issues and pull requests label Dec 18, 2024
@matheuscscp matheuscscp merged commit e106a11 into main Dec 18, 2024
1 check passed
@matheuscscp matheuscscp deleted the artifact-reconciler branch December 18, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
area/update-automation Flux update automation related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow a shorter reconciliation interval for the artifact
2 participants
@matheuscscp @stefanprodan