Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@commitlint/load has typescript listed in the dependencies instead of devDependencies #3420

Closed
simonecorsi opened this issue Nov 8, 2022 · 2 comments

Comments

@simonecorsi
Copy link

Hey 👋

As the title states, @commitlint/load has typescript (also ts-node) listed in the dependencies instead of devDeps, I'm using this programmatically in one of my projects and this dep only is generating 80mb larger builds, which is a lot.

I don't see any point in the code where typescript is used programmatically by @commitlint/load and I think it should be safe to move it in the devDependencies, or maybe am I missing something here?

@escapedcat
Copy link
Member

Hey @simonecorsi, yeah, agreed, but there's no easy way out currently. Have a look if your issue duplicates this one please: #3221

@simonecorsi
Copy link
Author

@escapedcat totally related thx, didn't find it when searched, I'll close this tho!

jrolfs added a commit to hoverinc/hover-javascript that referenced this issue Feb 27, 2023
…onfiguration

**@commitlint/cli** added support for TypeScript-based configurations via `ts-node`, and that has caused a good deal of grief:

conventional-changelog/commitlint#3420
conventional-changelog/commitlint#3351
conventional-changelog/commitlint#3218
conventional-changelog/commitlint#3256

hoverinc/web-react#1792

Both because it's a heavy-ass dependency and because it requires configuration to
work properly. It seems like project-local configuration can affect it's invocation
of ts-node, which happens even JavaScript configuration files now?... lame.

Anyways, this ensures we avoid any type-checking that happens in it's ts-node
invocation until we get a better solution upstream (or contribute one). Ideally,
installing ts-node would be opt-in etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants