-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [scope-enum] [scope-case] allow space after comma as scope delimiter #3576
Labels
Comments
miluoshi
added a commit
to miluoshi/commitlint
that referenced
this issue
Apr 4, 2023
miluoshi
added a commit
to miluoshi/commitlint
that referenced
this issue
Apr 4, 2023
miluoshi
added a commit
to miluoshi/commitlint
that referenced
this issue
Apr 4, 2023
Hm, would this also pass?: |
miluoshi
added a commit
to miluoshi/commitlint
that referenced
this issue
Apr 4, 2023
Maybe @karl-run has feedback to this |
miluoshi
changed the title
fix: [scope-enum] allow space after comma as scope delimiter
feat: [scope-enum] [scope-case] allow space after comma as scope delimiter
Apr 4, 2023
7 tasks
Yes, that would pass per implementation in #3577 |
miluoshi
added a commit
to miluoshi/commitlint
that referenced
this issue
Apr 4, 2023
miluoshi
added a commit
to miluoshi/commitlint
that referenced
this issue
Oct 25, 2023
escapedcat
pushed a commit
that referenced
this issue
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
scope-enum
andscope-case
rules should also accept comma with space,
as a delimiter in addition to/
,\
,,
Current Behavior
type(scope1,scope2,scope3): msg
passestype(scope1, scope2, scope3): msg
failsAffected packages
Possible Solution
No response
Steps to Reproduce
Context
It's quite common for developers to separate multiple scopes with
,
instead of,
. It leads to frustration finding thatcommitlint
failed just because of a space (which improves readability)commitlint --version
@commitlint/cli@17.4.4
git --version
v2.38.1
node --version
v18.12.1
The text was updated successfully, but these errors were encountered: