Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cz-commitlint searchable and easy to get start #2572

Merged
merged 8 commits into from
May 3, 2021
Merged

Make cz-commitlint searchable and easy to get start #2572

merged 8 commits into from
May 3, 2021

Conversation

curly210102
Copy link
Contributor

Description

Update package.json and README.md of cz-commitlint package

  1. add keywords of package.json
  2. simplify README, only introduce important points
  3. official document: provide a better screenshot and add "reference prompt" entry to sidebar

Motivation and Context

User can find "cz-commitlint" by keyword search.
Users can use it under clear instructions.

Usage examples

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@curly210102 curly210102 mentioned this pull request May 1, 2021
7 tasks
@escapedcat
Copy link
Member

Sometimes the circleci report doesn't work. We don't know why.
In circleci everything seems to look fine:
image

@curly210102 you have any idea? Otherwise I'll just merge this.

@curly210102
Copy link
Contributor Author

@escapedcat I have no idea, try to rerun?

@escapedcat
Copy link
Member

Can not find it here:
https://app.circleci.com/pipelines/github/conventional-changelog/commitlint

Only in yours:
https://app.circleci.com/pipelines/github/curly210102/commitlint/28/workflows/78f38403-1161-405f-8d3d-a4c2c96b4b82
And these are green.
On yours I'm not allowed to rerun checks:
image

You wanna click that and we'll see?

@curly210102
Copy link
Contributor Author

@escapedcat aha, it's the ci of my forked project, unfollowed it now.

@escapedcat
Copy link
Member

YAY!

@escapedcat escapedcat merged commit e37d3ea into conventional-changelog:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants