Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin cosmiconfig to specific version #3755

Merged
merged 9 commits into from
Nov 12, 2023

Conversation

joberstein
Copy link
Contributor

@joberstein joberstein commented Nov 10, 2023

Description

Pin cosmiconfig to specific version.

Motivation and Context

Yarn at least (maybe npm also?) doesn't update transitive dependencies, so any consuming apps that had installed a lower version of 8.x.x would face an issue by not pinning to a specific dependency because yarn won't update transitive dependencies if the installed one satisfies the requirement (e.g. 8.0.0 will satisfy ^8.0.0 even if it's not the latest 8.x.x).

Pinning a specific version so that installers will be forced to install the new version of comsiconfig when updating commitlint/cli or commitlint/load.

Resolves:

Caused by:

Usage examples

N/A

How Has This Been Tested?

Tested locally by installing the updated version in https://github.com/mikro-orm/mikro-orm which was facing this issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat
Copy link
Member

Thanks @joberstein and @newives !

@escapedcat escapedcat merged commit 636b8b1 into conventional-changelog:master Nov 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants