fix(rules): handle blank commit message in signed-off-by
rule
#4124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for an empty commit message for rule
signed-off-by
.Description
On a minimal environment with only
commitlint
installed and thesigned-off-by
rule set, writing an empty commit message would result in a runtime exception.Motivation and Context
Previously this rule caused a runtime exception trying to validate an empty commit message as it was trying to access the
startsWith
string method on an undefined value which was supposed to store the last line of the commit message. Now it does a check to see if the last line isundefined
or not.Types of changes
Checklist: