Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat(cli): add verbose option #606 #609

Closed
wants to merge 1 commit into from

Conversation

escapedcat
Copy link
Member

Adding --verbose option.

Description

Surpressing output on valid commits unless there are warnings.

Motivation and Context

#606

Usage examples

commitlint --verbose

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat escapedcat self-assigned this Apr 4, 2019
@escapedcat escapedcat requested review from byCedric and marionebl April 4, 2019 04:47
@escapedcat
Copy link
Member Author

I didn't add any tests yet. Let me know what you think. If this is ok I'll add tests for this.

@byCedric
Copy link
Member

byCedric commented Apr 5, 2019

Oh yeah I see, we need to do some test refactoring for this one 😄 I can help with that if necessary.

@byCedric
Copy link
Member

byCedric commented Apr 5, 2019

Just as a random thought, should this be considered a breaking change?

@escapedcat
Copy link
Member Author

@byCedric I'll find some time to adjust the tests. Just wanted your pre-approval first :)
And yes, might be breaking. I can imagine there are some users out there who use the valid-output in some way :)

Copy link
Contributor

@marionebl marionebl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the feature as proposed, let's do some tests and bring this in

@marionebl marionebl force-pushed the feat/606_add-verbose-option branch from 85c6e70 to 139e665 Compare April 26, 2019 14:17
@escapedcat escapedcat closed this May 5, 2019
@byCedric byCedric deleted the feat/606_add-verbose-option branch May 11, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants