Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Conventional changelog 3.1.x #166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jaszczw
Copy link

@jaszczw jaszczw commented Aug 26, 2019

Updates the reference to new conventional-changelog core. Adjusts preset option passing as it has changed between releases.

Adds ability to configure preset from config.

Adds a preset string to object conversion, to match new approach.

Signed-off-by: Wojciech Jaszczak <wojciech.jaszczak@x-team.com>
Signed-off-by: Wojciech Jaszczak <wojciech.jaszczak@x-team.com>
@hutson
Copy link
Contributor

hutson commented Sep 20, 2020

@jaszczw do these same changes need to be made to the conventional-gitlab-releaser package as well?

@jaszczw
Copy link
Author

jaszczw commented Sep 21, 2020

@hutson the conventional-gitlab-releaser will work as it's using conventional-changelog as dependency, and in the PR I've added a check if preset is passed as string or object - so conventional-gitlab-releaser referencing the freshest version of conventional-changelog should be fine without any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants