-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog links are incorrect for selfhosted gitlab #204
Comments
Is this the same as conventional-changelog/get-pkg-repo#9? |
Yes, I think it might be |
@stevemao i asked @a-jackson to look into it whilst I'm on holiday. So what he says goes :-) |
@AdamWillden : Does this PR (#174) answer your question ? |
@cdupetit yes that is it! #174 addresses this issue directly. Given we're both using gitlab I'd have been fine with a I'd love to have this working!! FWIW: I Inspected the changes in conventional-changelog/get-pkg-repo#9 in the end myself and didn't see how it would fix our problem after all (I forgot to report that here however). |
I'd be fine for you to reference this issue in that commit (such that merging will close this issue) |
@AdamWillden please see comments in #227 |
@AdamWillden we finally have this functionality, as of |
Thank you, very good of you to follow up and let me know. |
I know the code attempts to best guess at the host type (gitlab, github, etc) based on the
repository
settings in thepackage.json
, the changlog is then formatted with links as appropriate to the host type. Our gitlab server host name is very 'corporate' and unfriendly and does not contain the name 'gitlab'.I suspect that get-pkg-repo...index.js#L82 is returning an
unknownHostedInfo
object. I don't know for sure.I've looked through the code but cannot determine how best to fix this... I was hoping for something simple.
What would be great is if the user could specify what host type to use, and when not provided use the current auto-detection mechanism.
The text was updated successfully, but these errors were encountered: