Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog links are incorrect for selfhosted gitlab #204

Closed
AdamWillden opened this issue Aug 4, 2017 · 9 comments
Closed

Changelog links are incorrect for selfhosted gitlab #204

AdamWillden opened this issue Aug 4, 2017 · 9 comments

Comments

@AdamWillden
Copy link

AdamWillden commented Aug 4, 2017

I know the code attempts to best guess at the host type (gitlab, github, etc) based on the repository settings in the package.json, the changlog is then formatted with links as appropriate to the host type. Our gitlab server host name is very 'corporate' and unfriendly and does not contain the name 'gitlab'.

I suspect that get-pkg-repo...index.js#L82 is returning an unknownHostedInfo object. I don't know for sure.

I've looked through the code but cannot determine how best to fix this... I was hoping for something simple.

What would be great is if the user could specify what host type to use, and when not provided use the current auto-detection mechanism.

@stevemao
Copy link
Member

stevemao commented Sep 4, 2017

Is this the same as conventional-changelog/get-pkg-repo#9?

@a-jackson
Copy link

Yes, I think it might be

@AdamWillden
Copy link
Author

AdamWillden commented Sep 4, 2017

@stevemao i asked @a-jackson to look into it whilst I'm on holiday. So what he says goes :-)

@cdupetit
Copy link

@AdamWillden : Does this PR (#174) answer your question ?

@AdamWillden
Copy link
Author

@cdupetit yes that is it! #174 addresses this issue directly.

Given we're both using gitlab I'd have been fine with a --type gitlab style fix but I'm absolutely fine with the --context <context.json> fix you have proposed there which gives much finer control and may prove useful.

I'd love to have this working!!

FWIW: I Inspected the changes in conventional-changelog/get-pkg-repo#9 in the end myself and didn't see how it would fix our problem after all (I forgot to report that here however).

@AdamWillden
Copy link
Author

I'd be fine for you to reference this issue in that commit (such that merging will close this issue)

@bcoe
Copy link
Member

bcoe commented Nov 29, 2017

@AdamWillden please see comments in #227

@bcoe
Copy link
Member

bcoe commented May 5, 2019

@AdamWillden we finally have this functionality, as of standard-version@6.x.x, you can now create a .versionrc with custom URL formats see for all the config settings that are available.

@bcoe bcoe closed this as completed May 5, 2019
@AdamWillden
Copy link
Author

Thank you, very good of you to follow up and let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants