Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(changelog): allow to pass a custom context #552

Closed
wants to merge 1 commit into from
Closed

feat(changelog): allow to pass a custom context #552

wants to merge 1 commit into from

Conversation

dnlup
Copy link

@dnlup dnlup commented Feb 20, 2020

In repositories that are self-hosted most of the time the changelog is genereated with broken links that are missing the owner and the repository in the path.
Allowing to pass a custom context to conventionalChangelog mitigates this.

See issue #525 and #227.

.versionrc.js example configuration

module.exports = {
//...
context: {
  owner: 'some repo owner',
  repository: 'foo'
}

I saw #174 after opening this, sorry.

In repositories that are self-hosted most of the tim the changelog
is genereated with broken links. Allowing to pass a custom context
to conventionalChangelog mitigates this.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.442% when pulling 76bb460 on dnlup:feat/context into 2f04ac8 on conventional-changelog:master.

@dnlup
Copy link
Author

dnlup commented Feb 22, 2020

I am trying to figure out why the test fails on Windows. It will take a bit since I have to setup an environment for that. Any feedback is greatly appreciated in the meantime 🙏.

@dnlup
Copy link
Author

dnlup commented Feb 28, 2020

Maybe this work is not needed, I just saw #204 (comment).

@dnlup
Copy link
Author

dnlup commented Aug 7, 2020

Since I opened this PR, I found alternative solutions for the problems I thought it would have solved. I still think there is value in adding this feature, but for now, I don't have the time to work on it. So I will close this to avoid unnecessary noise and come back later.

@dnlup dnlup closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants