No need to bumb version in composer.lock and composer.json

[pvgnd]

closes #394

Composer docs states that version in composer.json is

Optional if the package repository can infer the version from somewhere, such as the VCS tag name in the VCS repository. In that case it is also recommended to omit it.

[coveralls]

Coverage remained the same at 99.429% when pulling 5428c51 on pvgnd:patch-1 into 8f36f9e on conventional-changelog:master.

[jbottigliero]

Hi @pvgnd, thanks for your contribution – this will need to be updated based on the changes to bump and package files that just landed in master, but this looks good to me and should be ok to release with the next major.

[pvgnd]

Actually, doesn't seem to be the right fix. The hash of the composer.lock depends on the composer.json content, so after bumping the version in composer.json, the composer.lock is not up to date with the new hash. So we need to run a postbump hook : composer update --lock

[jbottigliero]

@pvgnd maybe it makes sense to remove composer files from the default configuration altogether and provide an example for a composer-based library instead? Looking back on #394 and now that folks are better able to write their own updaters and bump files it might be the best route...

[tommywo]

@jbottigliero I agree. Also composer docs states that version in composer.json is

Optional if the package repository can infer the version from somewhere, such as the VCS tag name in the VCS repository. In that case it is also recommended to omit it.

So we should also include that in the docs.

[pvgnd]

I just rebased on master

[pvgnd]

@jbottigliero I just rebased the PR