-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS refers to webfonts through an absolute path. #1747
Comments
This corrects for an unfortunate characteristic of the Converse.js distribution, as tracked in conversejs/converse.js#1747
I tried to make this location depends on
I've added the two following lines to webpack.common.js:
Unfortunately, make dist continues to generate a css file with hardcoded /dist in the webfont location :-( |
The issue is still present in 6.0.0 and I would like to use it with relative paths, too. |
I'm not sure what can/should be done to fix this. Here's a relevant webpack issue: webpack-contrib/css-loader#155 From that issue:
We already do that AFAICT, in src/entry.js. |
As a workaround, you can build your own dist files and then specify the Like this: |
I've made a fix to not rewrite |
Great, thanks. I'll test it when 7f69394 will be included in a release. |
converse.css
andconverse.min.css
refer to the webfont location using an absolute path (under/dist/webfonts/
This makes it problematic to host Converse on a webserver in a context root other than one that is called 'dist'.
Please make the webfont location configurable or relative.
The text was updated successfully, but these errors were encountered: