Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard 2.0 #305

Merged
merged 21 commits into from
Aug 17, 2023
Merged

Dashboard 2.0 #305

merged 21 commits into from
Aug 17, 2023

Conversation

pawelkmpt
Copy link

@pawelkmpt pawelkmpt commented Aug 16, 2023 •
edited
Loading

@pawelkmpt pawelkmpt self-assigned this Aug 16, 2023
phkel and others added 20 commits August 16, 2023 11:53
@phkel @pawelkmpt
feat(cxl-ui): add cxl-stats component
a88b706 
https://app.clickup.com/t/861n0qjxj
@freudFlintstone @pawelkmpt
feat(cxl-ui): add cxl-course-card component
518baf1
@freudFlintstone @pawelkmpt
feat(cxl-ui): add cxl-timecomponent
cd3a8df
@freudFlintstone @pawelkmpt
refactor(cxl-ui): add cxlBaseCardElement as base class
ae15f87
@phkel @pawelkmpt
feat(cxl-lumo-styles): add badge secondary theme
0cadbd7 
https://app.clickup.com/t/861n0qm47
@phkel @pawelkmpt
feat(cxl-ui): add cxl-light-card component
07f53f1 
https://app.clickup.com/t/861n0qm47
@kertuilves @pawelkmpt
feat(cxl-ui): improve cxl-base-card component
f95209e 
https://app.clickup.com/t/861n0qm47
@kertuilves @pawelkmpt
feat(cxl-ui): refactor cxl-light-card component based on `cxl-base-…
938dc1d 
…card`

https://app.clickup.com/t/861n0qm47
@pawelkmpt
feat: add featured-course-card component
9155878 
https://app.clickup.com/t/861n0qjha
@kertuilves @pawelkmpt
feat(cxl-ui): improve cxl-base-card component
68cc69a 
https://app.clickup.com/t/861n0qjha
@kertuilves @pawelkmpt
feat(cxl-ui): refactor cxl-light-card component based on `cxl-base-…
355660a 
…card`

https://app.clickup.com/t/861n0qjha
@kertuilves @pawelkmpt
feat(cxl-ui): add cxl-notification-card component
a94d0cf 
https://app.clickup.com/t/861n0qm2v
@kertuilves @pawelkmpt
feat(cxl-ui): add cxl-dashboard-notification component
2313e1f 
https://app.clickup.com/t/861n0qm2v
@phkel @pawelkmpt
feat: add dashboard category accordion
45a85a0 
https://app.clickup.com/t/861n0qkvd
@phkel @pawelkmpt
feat(cxl-ui): add cxl-dashboard-header component
f0ebd94 
https://app.clickup.com/t/861n0qhy4
@kertuilves @pawelkmpt
feat(cxl-ui): add cxl-course-dialog component
736bd94 
https://app.clickup.com/t/861n0qm4w
@kertuilves @pawelkmpt
feat(cxl-ui): export new cxl components
ec09293
@kertuilves @pawelkmpt
feat(cxl-ui): add cxl-dashboard-layout story
5bb2a8a 
https://app.clickup.com/t/861n0qhnn
@kertuilves @pawelkmpt
feat(cxl-ui): fix dashboard components layout issues
282c6ce 
https://app.clickup.com/t/861n0qhnn
@pawelkmpt
chore(yarn): rebase on top of master
47c5739
@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited
Loading

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 61.63 KB (+69.87% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (-0.06% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 26.96 KB (+5.99% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (+1.3% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 237.19 KB (+13.72% 🔺)

@pawelkmpt
Copy link
Author

@kertuilves after rebasing feat/dashboard on top of master and resolving yarn.lock conflicts I see few issues with dashboard. Components. Look at the screenshots and comments below.

@pawelkmpt
Copy link
Author

cxl-course-dialog

As far as I remember dialog was not full width before. Do you confirm? If so, please fix it.

Screenshot 2023-08-16 at 12 18 45
Screenshot 2023-08-16 at 12 18 59

@pawelkmpt
Copy link
Author

cxl-dashboard-header

cxl-dashboard-notification

Different widths (margins/paddings ?) depending on the story.

Screenshot 2023-08-16 at 12 19 21
Screenshot 2023-08-16 at 12 19 36
Screenshot 2023-08-16 at 12 19 47

pawelkmpt
pawelkmpt commented Aug 17, 2023
View reviewed changes
Copy link
Author

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kertuilves some questions to you

packages/cxl-ui/scss/global/cxl-dashboard-header.scss Outdated Show resolved Hide resolved
packages/cxl-ui/src/components/cxl-app-layout.js Outdated Show resolved Hide resolved
@kertuilves kertuilves force-pushed the feat/dashboard branch 2 times, most recently from 405e384 to 3e83479 Compare August 17, 2023 08:59
@pawelkmpt pawelkmpt merged commit 13d9b44 into master Aug 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkraav lkraav Awaiting requested review from lkraav

@freudFlintstone freudFlintstone Awaiting requested review from freudFlintstone

@anoblet anoblet Awaiting requested review from anoblet

@kertuilves kertuilves Awaiting requested review from kertuilves

Assignees

@pawelkmpt pawelkmpt

Labels
CXL 2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pawelkmpt @lkraav @kertuilves @phkel @freudFlintstone