Merge pull request #208 from rudoc/master

Split MonitoredItemCreateRequest array to chunks
convertersystems · Aug 5, 2021 · a7d8da1 · a7d8da1
2 parents 5935207 + 15c28f6
commit a7d8da1
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/UaClient/ServiceModel/Ua/SubscriptionBase.cs b/UaClient/ServiceModel/Ua/SubscriptionBase.cs
@@ -565,10 +565,21 @@ private async Task StateMachineAsync(CancellationToken token = default)
                             if (items.Count > 0)
                             {
                                 var requests = items.Select(m => new MonitoredItemCreateRequest { ItemToMonitor = new ReadValueId { NodeId = ExpandedNodeId.ToNodeId(m.NodeId, this.InnerChannel.NamespaceUris), AttributeId = m.AttributeId, IndexRange = m.IndexRange }, MonitoringMode = m.MonitoringMode, RequestedParameters = new MonitoringParameters { ClientHandle = m.ClientId, DiscardOldest = m.DiscardOldest, QueueSize = m.QueueSize, SamplingInterval = m.SamplingInterval, Filter = m.Filter } }).ToArray();
+
+                                //split requests array to MaxMonitoredItemsPerCall chunks
+                                int maxmonitoreditemspercall = 100;
+                                MonitoredItemCreateRequest[] requests_chunk;
+                                int chunk_size;
+                                for (int i_chunk = 0; i_chunk < requests.Length; i_chunk += maxmonitoreditemspercall)
+                                {
+                                    chunk_size = Math.Min(maxmonitoreditemspercall, requests.Length - i_chunk);
+                                    requests_chunk = new MonitoredItemCreateRequest[chunk_size];
+                                    Array.Copy(requests, i_chunk, requests_chunk, 0, chunk_size);
+
                                 var itemsRequest = new CreateMonitoredItemsRequest
                                 {
                                     SubscriptionId = id,
-                                    ItemsToCreate = requests,
+                                    ItemsToCreate = requests_chunk,
                                 };
                                 var itemsResponse = await this.innerChannel.CreateMonitoredItemsAsync(itemsRequest);
 
@@ -593,6 +604,7 @@ private async Task StateMachineAsync(CancellationToken token = default)
                                     }
                                 }
                             }
+                            }
 
                             this.progress.Report(CommunicationState.Opened);