Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal DNS records based on Rack status, not app status #3467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beastawakens
Copy link
Collaborator

No description provided.

@beastawakens beastawakens added this to the 20210923 milestone Sep 23, 2021
@beastawakens beastawakens mentioned this pull request Sep 23, 2021
10 tasks
@beastawakens beastawakens removed this from the 20210923 milestone Oct 12, 2021
@beastawakens
Copy link
Collaborator Author

This covers a use case where on a Rack with mixed internal and public services, the 'local' DNS record for an app/service ([service].[app].[rack].convox) is directed at the public load balancer, so the internal services can't access it.

This change checks for the presence of an internal load balancer for the Rack and if it exists, the DNS record will now be pointed at that.

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #3467 (41fa7ae) into master (787a54a) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3467      +/-   ##
==========================================
+ Coverage   34.49%   34.52%   +0.02%     
==========================================
  Files         128      128              
  Lines       15566    15576      +10     
==========================================
+ Hits         5370     5377       +7     
- Misses       9279     9281       +2     
- Partials      917      918       +1     
Impacted Files Coverage Δ
provider/aws/releases.go 9.65% <0.00%> (-0.20%) ⬇️
pkg/logstorage/logstorage.go 87.91% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b1fca...41fa7ae. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants