Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix returned eventsource status code when not found #10

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Fix returned eventsource status code when not found #10

merged 3 commits into from
Jun 18, 2019

Conversation

aarranz
Copy link
Member

@aarranz aarranz commented Jun 18, 2019

Standard states that the correct status code is 204 instead of the normal 404.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 89.103%
Totals Coverage Status
Change from base Build 11: 0.04%
Covered Lines: 232
Relevant Lines: 251
💛 - Coveralls

@aarranz aarranz merged commit ddb92a1 into conwetlab:develop Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarranz @coveralls