-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change sentry integration #1820
Change sentry integration #1820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waw thank you! I have a few minor comments, and a bit I'm not too sure about logging. Looks good overall though.
{{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/taskapp/celery.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about https://github.com/pydanny/cookiecutter-django/blob/master/%7B%7Bcookiecutter.project_slug%7D%7D/config/wsgi.py? I think it should be changed as well.
@gfabricio mind resolving the merge conflicts? |
@gfabricio any news on this one? |
Is anyone using this change in production? Is it ready to use? |
What about the |
# Conflicts: # {{cookiecutter.project_slug}}/requirements/production.txt
{{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/taskapp/celery.py
Outdated
Show resolved
Hide resolved
# Conflicts: # {{cookiecutter.project_slug}}/config/settings/production.py # {{cookiecutter.project_slug}}/config/wsgi.py # {{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/taskapp/celery.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with and without Celery, errors are recorded properly.
fixes #1818
A simple screenshot running a django-cookiecutter based test project with the integration using sentry-sdk: