Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend docker test with deploy check #4838

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

foarsitter
Copy link
Collaborator

As the docs already mention, manage.py check --deploy requires the production settings, otherwise it fails on security related settings. In turn, running the production settings require the production dependencies.

This PR references the production requirements in requirements/local.txt so the dependencies like collectfast are available during development. This gives us the possibility to use the production settings in the local docker image and run check --deploy. For convenience I added the --database to check since they aren't run by default.

Fixes #4462

Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of adding more job to the CI, but actually that's much better.

Do you think it would be worth changing test_bare.sh to run this deploy check as well?

I haven't thought about this much, and I'm assuming that it's a similar level of complexity as test_docker.sh. If it's more complicated than that (need extra services to be runnning on CI), I wouldn't do it as part of this PR.

@foarsitter
Copy link
Collaborator Author

Do you think it would be worth changing test_bare.sh to run this deploy check as well?

I don't think it is worth it since the production settings do not contain any logic that differ between bare and docker.

@browniebroke
Copy link
Member

Do you think it would be worth changing test_bare.sh to run this deploy check as well?

I don't think it is worth it since the production settings do not contain any logic that differ between bare and docker.

fair enough. Anyway, LGTM! I will feel a tiny bit more confident in merging updates to our prod dependencies now. Thanks for that.

@foarsitter foarsitter merged commit 50b7ebf into cookiecutter:master Feb 7, 2024
13 checks passed
@foarsitter foarsitter deleted the production_check branch February 7, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage of production build/config
2 participants