Changes support version and Drops support for classic loader #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eudoxa
force-pushed
the
change_support_version
branch
3 times, most recently
from
4c707fa to
3853479
Compare
eudoxa
force-pushed
the
change_support_version
branch
from
3853479 to
d963310
Compare
eudoxa
changed the title
nekketsuuu
approved these changes
Apr 30, 2024
.github/workflows/master_and_pr.yml
Outdated
Comment on lines
20
to
21
| autoloader: | ||
| - "zeitwerk" |
There was a problem hiding this comment.
nit: matrix.autoloader の利用箇所がもう無いので、ここは全部削除できます。
gemfiles/Gemfile_rails_7.0.rb
Outdated
| gem 'rails', '~> 5.0.0' | ||
| gem 'sqlite3', '~> 1.3.6' | ||
| gem 'rails', '~> 7.0.0' | ||
| gem "sqlite3", "~> 1.4" |
There was a problem hiding this comment.
nit: double quotes になっていて揃っていないのが気になります。Rails 7.1 の方も同様です。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#79 のPRで行おうとした下記の変更のうち、2に加え、提案のあった「Classicモードの削除」を追加したPRです。
また、上記のPRでは含まなかったものの、Modelの拡張も利用実績がないことを利用にv3.0.0で一緒に廃止をしようと思い、削除PRを作成しました。こちらもマージ後にDraftを外します。 #82
@cookpad/infra レビューをお願いします