-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TruffleRuby in CI #37
Conversation
I should have marked this as a Draft PR since it's not ready yet, sorry. |
Should be good now, the next truffleruby-dev build will have the needed fix (oracle/truffleruby@00454d0) and should pass CI. |
@sorah Could you review and merge this? The CI passes: https://github.com/eregon/grpc_kit/runs/7992255982?check_suite_focus=true |
We're happy to run a CI against truffleruby but could you add separate job for truffleruby? because at this moment we don't want to (and we can't) guarantee any changes works well on truffleruby, while we fully support MRIs. |
It's already its own "CI job" (https://github.com/eregon/grpc_kit/runs/7992255982?check_suite_focus=true), I'm not sure what you mean. |
I pushed that. |
Yes I meant this |
Thanks! |
On top of #36 to get those fixes.
Still needs a small fix in TruffleRuby to add
exception:
keyword to StringIO first, cc @andrykonchin (oracle/truffleruby#2247 (comment)).