Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TruffleRuby in CI #37

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Add TruffleRuby in CI #37

merged 3 commits into from
Aug 24, 2022

Conversation

eregon
Copy link
Contributor

@eregon eregon commented Aug 22, 2022

On top of #36 to get those fixes.
Still needs a small fix in TruffleRuby to add exception: keyword to StringIO first, cc @andrykonchin (oracle/truffleruby#2247 (comment)).

@eregon
Copy link
Contributor Author

eregon commented Aug 22, 2022

I should have marked this as a Draft PR since it's not ready yet, sorry.

@eregon
Copy link
Contributor Author

eregon commented Aug 23, 2022

Should be good now, the next truffleruby-dev build will have the needed fix (oracle/truffleruby@00454d0) and should pass CI.

@eregon
Copy link
Contributor Author

eregon commented Aug 24, 2022

@sorah Could you review and merge this?

The CI passes: https://github.com/eregon/grpc_kit/runs/7992255982?check_suite_focus=true

@sorah
Copy link
Member

sorah commented Aug 24, 2022

We're happy to run a CI against truffleruby but could you add separate job for truffleruby? because at this moment we don't want to (and we can't) guarantee any changes works well on truffleruby, while we fully support MRIs.

@eregon
Copy link
Contributor Author

eregon commented Aug 24, 2022

It's already its own "CI job" (https://github.com/eregon/grpc_kit/runs/7992255982?check_suite_focus=true), I'm not sure what you mean.
But I can use a different entry under jobs:, yes.

@eregon
Copy link
Contributor Author

eregon commented Aug 24, 2022

I pushed that.

@sorah
Copy link
Member

sorah commented Aug 24, 2022

But I can use a different entry under jobs:, yes.

Yes I meant this

@sorah sorah merged commit 1dcc2c0 into cookpad:master Aug 24, 2022
@eregon
Copy link
Contributor Author

eregon commented Aug 24, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants