Alter {users,job_definitions}.id to bigint #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update spec/dummy/db/schema.rb by running the migration? |
riseshia
force-pushed
the
alter
branch
2 times, most recently
from
88a2658 to
366e186
Compare
|
Changed(rebased):
|
eagletmt
reviewed
May 18, 2018
| @@ -0,0 +1,37 @@ | |||
| class AlterKeyAndIndexToBigint < ActiveRecord::Migration[5.0] | |||
| def up | |||
| change_column :job_definitions, :id, :bigint, unsigned: false, auto_increment: true | |||
There was a problem hiding this comment.
Why is unsigned: false needed? Isn't it default?
There was a problem hiding this comment.
you're right ;) I removed it. (rebased)
There is the problem that some tables has different type of primary key from its installed: - before 0.2.0: using unsigned int for primary key - after 0.2.0: using signed int for primary key This problem was made by fa75b20. This makes hard to keep consistency of code / infra. For instance, we need to care about 2 types of primary when adding foreign key. Actually, this is already blocker of cookpad#110 To solve the problem, this patch proposes to alter these primary key to bigint, which is next default type of rails.
eagletmt
approved these changes
May 18, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is the problem that some tables has different type of primary key from
its installed:
This problem was made by fa75b20.
This makes hard to keep consistency of code / infra.
For instance, we need to care about 2 types of primary when adding foreign key.
Actually, this is already blocker of #110
To solve the problem, this patch proposes to alter these primary key to
bigint, which is next default type of rails.
Please review this @cookpad/dev-infra
cc @takonomura