Prevent from propagating env vars at outside of fork task scope #128
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eagletmt
approved these changes
Jun 3, 2019
| attributes = attributes.merge(uuid: SecureRandom.uuid, parent: token, script: child_node.to_script, path: '/') | ||
| attributes['context'] = token.context.deep_dup |
There was a problem hiding this comment.
(nit) this assignment can be merged into the above line
attributes = token.attributes.except('id', 'uuid', 'script', 'path', 'message', 'created_at', 'updated_at', 'context')
attributes = attributes.merge(uuid: SecureRandom.uuid, parent: token, script: child_node.to_script, path: '/', context: token.context.deep_dup)Since deserialized context value of Token model by getting through AttributeSet#attributes is passed by reference, additional env values passed to create_child_token method overwrite a context which a token instance variable has. This cause unintentional env values propagation like KUROKO2_PARALLEL_FORK_SIZE at outside of the fork task scope. To avoid this, use the deep copy for context value instead.
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since deserialized context value of Token model by getting through
AttributeSet#attributes is passed by reference, additional env values
passed to create_child_token method overwrite a context which a token
instance variable has. This cause unintentional env values propagation
like KUROKO2_PARALLEL_FORK_SIZE at outside of the fork task scope.
To avoid this, use the deep copy for context value instead.
@cookpad/infra please review