Upgrade html-pipeline to v3 and drop support for Ruby <= 3.0 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coord-e
force-pushed
the
html-pipeline-3.0
branch
from
fea5588 to
318582a
Compare
Merged
|
Hmm html-pipeline v3 requires Ruby ~> 3.1, so we need to bump minimum supported Ruby version. |
coord-e
force-pushed
the
html-pipeline-3.0
branch
from
57bd83d to
8abe619
Compare
coord-e
changed the title
nekketsuuu
approved these changes
Feb 8, 2024
eagletmt
approved these changes
Feb 9, 2024
hfm
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current kuroko2 won't work with latest version (v3) of html-pipeline which contains a breaking change from v2. This PR contains changes to migrate kuroko2 to html-pipeline v3. This PR also fixes a spec which is broken by commonmarker v1.
I briefly confirmed proper rendering of job descriptions using local Kuroko2 instance.
@cookpad/infra could you please review?