Add tags to job list #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems ci has broken |
k0kubun
reviewed
Nov 16, 2016
| =link_to tag.name, job_definitions_path('tag': [tag.name]), class: 'label label-default spacer-right-3' | ||
| = first_line(definition.description) | ||
| td | ||
| = link_to raw('<i class="fa fa-chevron-right"></i> <span class="small">View Details</span>'), definition, class: 'btn btn-sm btn-default' |
There was a problem hiding this comment.
Can we use = link_to definition, class: 'btn btn-sm btn-default' do ...? Specifying raw by hand is dangerous.
There was a problem hiding this comment.
Fixed 37182b6.
But there are many raw functions in kuroko2 views 🤕
k0kubun
reviewed
Nov 16, 2016
| th.col-md-1 | ||
| - for definition in definitions | ||
| tr | ||
| td | ||
| span.star-holder | ||
| = star_link_for(definition) | ||
| td= definition.id | ||
| td.no-decorate= link_to definition.name, definition | ||
| td.no-decorate= link_to definition.name, definition, class: '' |
There was a problem hiding this comment.
Why is this change necessary?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retry of #20 .
cc: @hogelog @cookpad/dev-infra