Kill n+1 queries and fix tag links #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adorechic
reviewed
Nov 18, 2016
| @@ -2,7 +2,7 @@ class Kuroko2::JobDefinitionsController < Kuroko2::ApplicationController | |||
| before_action :set_definition, only: [:show, :edit, :update, :destroy] | |||
|
|
|||
| def index | |||
| rel = Kuroko2::JobDefinition | |||
| rel = Kuroko2::JobDefinition.joins(:admins).includes(:tags, :job_instances, :job_schedules, :admins) | |||
There was a problem hiding this comment.
why do you join admins not only including it? (I don't know about table structures)
There was a problem hiding this comment.
The admins is a has_many :through association. it do not work only includes.
| @@ -21,7 +21,7 @@ | |||
| td= labeled_status(definition.job_instances.take) | |||
| td | |||
| - definition.tags.each do |tag| | |||
| =link_to tag.name, root_path('tag': [tag.name]), class: 'label label-default spacer-right-3' | |||
| =link_to tag.name, { 'tag': [tag.name] }, class: 'label label-default spacer-right-3' | |||
There was a problem hiding this comment.
why don't you use named routes path?
There was a problem hiding this comment.
Because this partial view used in dashboards and user details pages (/users/:id).
There was a problem hiding this comment.
ic, this view is used both of dashboard and user pages, and you want to link to each of them.
btw, { tag: [tag.name] }
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.