Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foreman to development dependency gem list #30

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Add foreman to development dependency gem list #30

merged 1 commit into from
Dec 16, 2016

Conversation

inohiro
Copy link
Contributor

@inohiro inohiro commented Dec 9, 2016 •
edited
Loading

As in quick start, I need to install foreman additionally.
So I think foreman gem is put in dependencies of development gemspec.

What do you think?

@eisuke
Copy link
Member

eisuke commented Dec 9, 2016

Thank you. I agree necessity of foreman installation.

But Kuroko2 gem does not use foreman gem.
I think foreman should be included in application's Gemfile generated by app_template.rb.

@inohiro
Copy link
Contributor Author

inohiro commented Dec 9, 2016

@eisuke I moved foreman to app_template.rb ;)

eisuke
eisuke approved these changes Dec 9, 2016
View reviewed changes
Copy link
Member

@eisuke eisuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eisuke eisuke merged commit c2353f9 into cookpad:master Dec 16, 2016
@inohiro inohiro deleted the foreman_gemfile branch December 17, 2016 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eisuke eisuke eisuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inohiro @eisuke