Refactor configurations #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Rails 4.2 YAML configuration files can be easily loaded with the new config_for
occured with: RUBYOPT="-w" bundle exec rspec spec message `warning: character class has duplicated range`
eagletmt
requested changes
Jan 1, 2017
| @@ -11,8 +11,7 @@ def execute | |||
| end | |||
|
|
|||
| def auto_skip_error? | |||
| return @auto_skip_error if defined? @auto_skip_error | |||
| @auto_skip_error = option ? TRUE_OPTIONS.include?(option.strip) : false | |||
| @auto_skip_error ||= option ? TRUE_OPTIONS.include?(option.strip) : false | |||
There was a problem hiding this comment.
@auto_skip_error was already memoized, but this change breaks the memoization.
When option or TRUE_OPTIONS.include?(option.strip) is evaluated to false, @auto_skip_error ||= expr is evaluated every time.
There was a problem hiding this comment.
When option or TRUE_OPTIONS.include?(option.strip) is evaluated to false, @auto_skip_error ||= expr is evaluated every time.
Thank you for reviewing!
I'll remove the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
config_formethod to load configuration files easily. The method supported after Rails version 4.2.RUBYOPT="-w"option.[\w_-]has a duplicate character range between\wand_.Memoized instance valiable:@auto_skip_error