Allow user to receive notification #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eisuke
reviewed
Feb 14, 2017
| if (Notification.permission === 'granted' && Cookies.get('notification') === 'on') { | ||
| var notification = new Notification( | ||
| "[" + status + "] " + name, | ||
| {"icon": window.location.origin + "/assets/kuroko2/kuroko-logo-" + status.toLowerCase() + ".png"} |
There was a problem hiding this comment.
It is not necessarily to mount kuroko2 engine on root.
How about using the rails generated path or URL in any data attribute?
There was a problem hiding this comment.
Assets within an engine are put into /assets path. This code will work.
There was a problem hiding this comment.
Oops... I'm sorry, what I pointed out is mistake 😢
But the same situation will occur using config.assets.prefix or config.action_controller.asset_host, right?
There was a problem hiding this comment.
Your are right. I will change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to receive a notification when the job is finished.
UI
Example