Fix not executing multiple fork tasks #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorah
reviewed
May 30, 2017
| def children | ||
| token.context['fork_children_ids'] ||= {} | ||
| child_ids = token.context['fork_children_ids'][token.path] ||= [] | ||
| if child_ids.present? |
| @@ -44,6 +53,7 @@ def create_child_token(child_node:, env: {}) | |||
| attributes['context']['ENV'] = (attributes['context']['ENV'] || {}).merge(env) | |||
|
|
|||
| Token.create!(attributes).tap do |created| | |||
| token.context['fork_children_ids'][token.path] << created.id | |||
There was a problem hiding this comment.
No, It is always Array.
But I came to feel it is hard to notice. fixed aad3d24
sorah
reviewed
May 30, 2017
| @@ -32,6 +31,19 @@ def validate | |||
|
|
|||
| private | |||
|
|
|||
| def children | |||
| if fork_children_ids.present? | |||
There was a problem hiding this comment.
this should be always Array; empty? is enough. present? doesn't perform a empty-ness check only.
There was a problem hiding this comment.
Fixed it in 7d5f388 (Also fix redundant repeating empty?).
eisuke
force-pushed
the
fix_multiple_forks
branch
from
7d5f388 to
73740a5
Compare
eagletmt
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug #62
@cookpad/dev-infra please review.