Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify expected_time warnings from the root task only #66

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Notify expected_time warnings from the root task only #66

merged 1 commit into from
Jun 19, 2017

Conversation

eisuke
Copy link
Member

@eisuke eisuke commented Jun 1, 2017

If running time in the job having fork or parallel_fork tasks passed expected_time, Kuroko2 warn from all tasks. It is noisy.
So this PR prevents it, and expected_time do not depend on a execute task.

@cookpad/dev-infra 👓

@eisuke eisuke merged commit 73f60e8 into cookpad:master Jun 19, 2017
@eisuke eisuke deleted the fix_expected_time branch June 19, 2017 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aamine aamine aamine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eisuke @aamine