Add execution_id to process_signals table and use it #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm planning to implement a new worker like command-executor. Since it doesn't run commands in the same host but runs commands in Amazon ECS, process_signals cannot have meaningful pid and hostname. I think process_signals actually references executions, so I've added execution_id column to process_signals table.
|
Fixed error when no worker is associated with the execution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning to implement a new worker like command-executor.
Since it doesn't run commands in the same host but runs commands in
Amazon ECS, process_signals cannot have meaningful pid and hostname. I
think process_signals actually references executions, so I've added
execution_id column to process_signals table.
@eisuke @takai @cookpad/dev-infra please review