Add users_controller#edit #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adorechic
suggested changes
Nov 9, 2016
| def update | ||
| @user_name = @user.name | ||
|
|
||
| @user.email = user_params[:email] |
There was a problem hiding this comment.
why don't you use @user.update(user_params) ?
| end | ||
|
|
||
| def update | ||
| @user_name = @user.name |
There was a problem hiding this comment.
Looks as confusing ivar. I prefer to use @user.user_name_was
- @title = "#{@user.user_name_was} « Users"|
|
||
| it 'edits the name/email' do | ||
| expect(assigns(:user).reload.name).to eq(name) | ||
| expect(assigns(:user).reload.email).to eq(email) |
| let(:provider) { Kuroko2::User::GOOGLE_OAUTH2_PROVIDER } | ||
|
|
||
| it 'returns bad request' do | ||
| expect(response).to be_bad_request |
There was a problem hiding this comment.
[IMO] I prefer to use to have_http_status(:bad_request) because it provides more readable failure message
| div class="form-group #{@user.errors.has_key?(:name) ? 'has-error' : ''}" | ||
| = form.label :name | ||
| = form.text_field :name, class: 'form-control', placeholder: 'Group Name' | ||
| div class="form-group #{@user.errors.has_key?(:email) ? 'has-error' : ''}" |
There was a problem hiding this comment.
don't you show validation error messages?
|
LGTM |
adorechic
approved these changes
Nov 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cookpad/dev-infra