Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show SUSPENDED label to list of job definitions #99

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

takonomura
Copy link
Contributor

@takonomura takonomura commented Jan 26, 2018

Before:
definitions_before

After:
definitions_after

@ganmacs
Copy link
Contributor

ganmacs commented Jan 26, 2018

@cookpad/dev-infra Review please.

@ganmacs
Copy link
Contributor

ganmacs commented Jan 26, 2018

The position you added the suspended label is used for tags and description.
So I think that one is not suitable for adding suspended label. What do you think?

@takonomura
Copy link
Contributor Author

Where is better to adding suspended label?

@eisuke
Copy link
Member

eisuke commented Jan 26, 2018

How about putting it the head of name columns?

@takonomura
Copy link
Contributor Author

I moved it in 2f785a7.

Copy link
Contributor

@ganmacs ganmacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ganmacs ganmacs merged commit f9fe7a9 into cookpad:master Jan 29, 2018
@takonomura takonomura deleted the add-suspended-label branch January 30, 2018 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants