Remove template provider #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resource comes from the template provider which is now deprecated, and cannot be used by users on M1 macs. Instead of implementing multi-part cloud-init in native terraform e.g. https://github.com/ned1313/terraform-cloudinit-native I have just removed the ability to pass in additional `cloud_config` parts. We as far as I can tell are not currently using this feature anyway internally at cookpad, and it wasn't even avalible on the bottlerocket variant.
errm
requested review from
a team,
gabgla and
sikachu
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
My approach here was to remove a feature to make implementation much simpler - so we will need to update this in the UPGRADING document as a breaking change.