Fix bug where wrong bottlerocket volume is resized #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bottlerocket AMI defines 2 EBS volumes - the first `/dev/xvda` is an immutable volume containing operating system itself and doesn't need to be resized. The second volume `/dev/xvdb` is used for all the userspace data - container images, tmp etc, and is the thing we should resize based on this modules config. re: https://github.com/bottlerocket-os/bottlerocket#default-volumes
errm
requested review from
rikarumi and
piotr-zuralski
and removed request for
a team
piotr-zuralski
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bottlerocket AMI defines 2 EBS volumes - the first
/dev/xvdais animmutable volume containing operating system itself and doesn't need to be
resized.
The second volume
/dev/xvdbis used for all the userspace data -container images, tmp etc, and is the thing we should resize based on
this modules config.
re: https://github.com/bottlerocket-os/bottlerocket#default-volumes