Enhancements from web-platform #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errm
requested review from
arunagw,
ezavgorodniy,
jportasa,
pray and
a team
and removed request for
a team
errm
force-pushed
the
errm/remove-cluster-waiting-provisioner
branch
from
0365d2a to
1ac1c20
Compare
pray
approved these changes
Mar 17, 2023
ettiee
reviewed
Mar 17, 2023
| @@ -23,7 +23,7 @@ data "aws_iam_policy_document" "aws_ebs_csi_driver_assume_role_policy" { | |||
|
|
|||
| resource "aws_iam_role" "aws_ebs_csi_driver" { | |||
| count = local.aws_ebs_csi_driver_iam_role_count | |||
| name = "EksEBSCSIDriver-${var.name}" | |||
| name = "${var.iam_role_name_prefix}EksEBSCSIDriver-${var.name}" | |||
There was a problem hiding this comment.
Suggested change
| name = "${var.iam_role_name_prefix}EksEBSCSIDriver-${var.name}" | |
| name = "${var.iam_role_name_prefix}-EksEBSCSIDriver-${var.name}" |
would be nice for readability - or do you need this as-written to be compatible with with what you've implemented for the web platform clusters?
There was a problem hiding this comment.
I think this makes the prefix non optional (default role name will be -EksEBSCSIDriver-nanana)?
There was a problem hiding this comment.
Perhaps we can do something like
Suggested change
| name = "${var.iam_role_name_prefix}EksEBSCSIDriver-${var.name}" | |
| name = join("-", compact([var.iam_role_name_prefix, "EksEBSCSIDriver", var.name])) |
There was a problem hiding this comment.
🤷 then we have - in the middle of camelcased names though
GlobalWebPlatformEksEBSCSIDriver-clustername
vs
GlobalWebPlatform-EksEBSCSIDriver-clustername
There was a problem hiding this comment.
ah yes neater than the suggestion I was mid-writing with a var null condition ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 These are some enhancements we have been using on the web platform clusters for some time!
It would be great to merge them in so we can use the mainline release!