Enable to use Karpenter v1 controller policy #371
Merged
+424
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coord-e
force-pushed
the
coord-e/karpenter-v1-controller-policy
branch
from
2465d61 to
bcf7a28
Compare
errm
reviewed
Oct 24, 2024
coord-e
force-pushed
the
coord-e/karpenter-v1-controller-policy
branch
2 times, most recently
from
04485e2 to
00744e8
Compare
coord-e
force-pushed
the
coord-e/karpenter-v1-controller-policy
branch
from
00744e8 to
c820fe1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Including both v1 and v1beta policies inline in the role seems to exceed the IAM role's policy size limit. I resolved this with managed policies, now tests are passing 7257bc8 |
|
thank you! |
coord-e
added a commit
that referenced
this pull request
Oct 30, 2024
This is a squashed commit with changes in #371: Enable to detach Karpenter v1beta controller policy Make v1 and v1beta policies mutually exclusive Use Karpenter v1 resources in test Revert "Make v1 and v1beta policies mutually exclusive" This reverts commit 0db1769. Separate policy documents as managed policies
coord-e
added a commit
that referenced
this pull request
Oct 30, 2024
This is a squashed commit with changes in #371: Enable to detach Karpenter v1beta controller policy Make v1 and v1beta policies mutually exclusive Use Karpenter v1 resources in test Revert "Make v1 and v1beta policies mutually exclusive" This reverts commit 0db1769. Separate policy documents as managed policies
This was referenced Oct 30, 2024
coord-e
added a commit
that referenced
this pull request
Oct 30, 2024
This is a squashed commit with changes in #371, along with some modifications to match the state of the 1.29 release branch: Enable to detach Karpenter v1beta controller policy Make v1 and v1beta policies mutually exclusive Use Karpenter v1 resources in test Revert "Make v1 and v1beta policies mutually exclusive" This reverts commit 0db1769. Separate policy documents as managed policies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attaches a controller policy for Karpenter v1 in the karpenter module. The policy content is taken from https://github.com/aws/karpenter-provider-aws/blob/v1.0.6/website/content/en/preview/getting-started/getting-started-with-karpenter/cloudformation.yaml. I've added module variables
v1andv1betato help migration as you did in #368.I'll make a PR to backport this to v0.29 and v0.30 after this is merged.