Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More thorough tests #22

Closed
cookpete opened this issue Jan 3, 2016 · 1 comment
Closed

More thorough tests #22

cookpete opened this issue Jan 3, 2016 · 1 comment

Comments

@cookpete
Copy link
Owner

cookpete commented Jan 3, 2016

Shallow rendering unit tests only get us so far. It's worth investigating into more heavyweight test utils. Perhaps something like this setup with karma
@cookpete
Copy link
Owner Author

cookpete commented Jan 4, 2016

I've been setting up karma tests in a branch of my react-transform-boilerplate fork and it seems to work nicely (for basic rendering at least).

Considering I plan to rebase this repo on that boilerplate, adding karma tests for react-player should be fairly easy after that.

cookpete added a commit that referenced this issue Jan 5, 2016
@cookpete
Add basic karma testing
01c7483 
Closes #22
cookpete added a commit that referenced this issue Jan 5, 2016
@cookpete
Add basic karma testing
9c9b52c 
Closes #22
cookpete added a commit that referenced this issue Jan 5, 2016
@cookpete
Add basic karma testing
210505c 
Closes #22
cookpete added a commit that referenced this issue Jan 5, 2016
@cookpete
Add basic karma testing
869c1e7 
Closes #22
cookpete added a commit that referenced this issue Jan 5, 2016
@cookpete
Add basic karma testing
65b82c0 
Closes #22
cookpete added a commit that referenced this issue Jan 5, 2016
@cookpete
Add basic karma testing
2f41434 
Closes #22
For some reason the players do not work in Firefox on Travis, and I don't know why
See https://travis-ci.org/CookPete/react-player/jobs/100382039 for a travis log with SoundCloud debug logs
It seems to load the track correctly and run play(), but the stateChange event never happens (and so onPlay is never fired)
cookpete added a commit that referenced this issue Jan 5, 2016
@cookpete
Add basic karma testing
b495618 
Closes #22
For some reason the players do not work in Firefox on Travis, and I don't know why
See https://travis-ci.org/CookPete/react-player/jobs/100382039 for a travis log with SoundCloud debug logs
It seems to load the track correctly and run play(), but the stateChange event never happens (and so onPlay is never fired)
cookpete added a commit that referenced this issue Jan 6, 2016
@cookpete
Add basic karma testing
1ddec71 
Closes #22
For some reason the players do not work in Firefox on Travis, and I don't know why
See https://travis-ci.org/CookPete/react-player/jobs/100382039 for a travis log with SoundCloud debug logs
It seems to load the track correctly and run play(), but the stateChange event never happens (and so onPlay is never fired)
cookpete added a commit that referenced this issue Jan 7, 2016
@cookpete
Add basic karma testing
447cf60 
Closes #22
For some reason the players do not work in Firefox on Travis, and I don't know why
See https://travis-ci.org/CookPete/react-player/jobs/100382039 for a travis log with SoundCloud debug logs
It seems to load the track correctly and run play(), but the stateChange event never happens (and so onPlay is never fired)
cookpete added a commit that referenced this issue Jan 7, 2016
@cookpete
Add basic karma testing
9e7638a 
Closes #22
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
Add basic karma testing
17824a0 
Closes cookpete/react-player#22
@mgw-sbex mgw-sbex mentioned this issue Jan 25, 2019
Closed
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
Add basic karma testing
7c75d9e 
Closes cookpete/react-player#22
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
@albanqoku
Add basic karma testing
3ce9ac5 
Closes cookpete/react-player#22
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
@Webmaster1116
Add basic karma testing
8b1b846 
Closes cookpete/react-player#22
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
@webmiraclepro
Add basic karma testing
e776331 
Closes cookpete/react-player#22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cookpete