-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More thorough tests #22
Comments
I've been setting up Considering I plan to rebase this repo on that boilerplate, adding |
cookpete
added a commit
that referenced
this issue
Jan 5, 2016
Closes #22 For some reason the players do not work in Firefox on Travis, and I don't know why See https://travis-ci.org/CookPete/react-player/jobs/100382039 for a travis log with SoundCloud debug logs It seems to load the track correctly and run play(), but the stateChange event never happens (and so onPlay is never fired)
cookpete
added a commit
that referenced
this issue
Jan 5, 2016
Closes #22 For some reason the players do not work in Firefox on Travis, and I don't know why See https://travis-ci.org/CookPete/react-player/jobs/100382039 for a travis log with SoundCloud debug logs It seems to load the track correctly and run play(), but the stateChange event never happens (and so onPlay is never fired)
cookpete
added a commit
that referenced
this issue
Jan 6, 2016
Closes #22 For some reason the players do not work in Firefox on Travis, and I don't know why See https://travis-ci.org/CookPete/react-player/jobs/100382039 for a travis log with SoundCloud debug logs It seems to load the track correctly and run play(), but the stateChange event never happens (and so onPlay is never fired)
cookpete
added a commit
that referenced
this issue
Jan 7, 2016
Closes #22 For some reason the players do not work in Firefox on Travis, and I don't know why See https://travis-ci.org/CookPete/react-player/jobs/100382039 for a travis log with SoundCloud debug logs It seems to load the track correctly and run play(), but the stateChange event never happens (and so onPlay is never fired)
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this issue
Dec 23, 2018
Closed
david-hub024
pushed a commit
to david-hub024/React_VideoPlayer
that referenced
this issue
May 23, 2020
albanqoku
added a commit
to albanqoku/react-player
that referenced
this issue
Feb 24, 2021
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this issue
May 20, 2021
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this issue
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Shallow rendering unit tests only get us so far. It's worth investigating into more heavyweight test utils. Perhaps something like this setup with
karma
The text was updated successfully, but these errors were encountered: