Destroy hls player on changing source. Unit test is included. #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webmaster1116
added a commit
to Webmaster1116/video-player
that referenced
this pull request
May 20, 2021
webmiraclepro
added a commit
to webmiraclepro/video-player
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour: On change source we creating new HLS player but the old one still exists and continue to download the manifest. If we switch 2-3 channels we have 2-3 working hls players and HLS errors begin.
Fix: We are destroying hls player instance before creating the new one. No more errors and additional traffic. Unit test was included.