fix: smtp encryption

coollabsio · Dec 23, 2024 · 1f6c614 · 1f6c614
1 parent f2cb040
commit 1f6c614
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/app/Notifications/Channels/EmailChannel.php b/app/Notifications/Channels/EmailChannel.php
@@ -66,17 +66,24 @@ private function bootConfigs($notifiable): void
         }
 
         if ($emailSettings->smtp_enabled) {
+            $encryption = match (strtolower($emailSettings->smtp_encryption)) {
+                'starttls' => null,
+                'tls' => 'tls',
+                'none' => null,
+                default => null,
+            };
+
             config()->set('mail.default', 'smtp');
             config()->set('mail.mailers.smtp', [
                 'transport' => 'smtp',
                 'host' => $emailSettings->smtp_host,
                 'port' => $emailSettings->smtp_port,
-                'encryption' => $emailSettings->smtp_encryption === 'none' ? null : $emailSettings->smtp_encryption,
+                'encryption' => $encryption,
                 'username' => $emailSettings->smtp_username,
                 'password' => $emailSettings->smtp_password,
                 'timeout' => $emailSettings->smtp_timeout,
                 'local_domain' => null,
-                'auto_tls' => $emailSettings->smtp_encryption === 'none' ? '0' : '',
+                'auto_tls' => $emailSettings->smtp_encryption === 'none' ? '0' : '', // If encryption is "none", it will not try to upgrade to TLS via StartTLS to make sure it is unencrypted.
             ]);
         }
     }

diff --git a/bootstrap/helpers/notifications.php b/bootstrap/helpers/notifications.php
@@ -67,17 +67,26 @@ function set_transanctional_email_settings(?InstanceSettings $settings = null):
 
         return 'resend';
     }
+
+    $encryption = match (strtolower(data_get($settings, 'smtp_encryption'))) {
+        'starttls' => null,
+        'tls' => 'tls',
+        'none' => null,
+        default => null,
+    };
+
     if (data_get($settings, 'smtp_enabled')) {
         config()->set('mail.default', 'smtp');
         config()->set('mail.mailers.smtp', [
             'transport' => 'smtp',
             'host' => data_get($settings, 'smtp_host'),
             'port' => data_get($settings, 'smtp_port'),
-            'encryption' => data_get($settings, 'smtp_encryption'),
+            'encryption' => $encryption,
             'username' => data_get($settings, 'smtp_username'),
             'password' => data_get($settings, 'smtp_password'),
             'timeout' => data_get($settings, 'smtp_timeout'),
             'local_domain' => null,
+            'auto_tls' => data_get($settings, 'smtp_encryption') === 'none' ? '0' : '', // If encryption is "none", it will not try to upgrade to TLS via StartTLS to make sure it is unencrypted.
         ]);
 
         return 'smtp';