-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Fix all deletion issues, add graceful shutdown to everything, new delete confirmation process #3024
Merged
andrasbacsai
merged 99 commits into
coollabsio:next
from
peaklabs-dev:fix-#2546-deletion-issues
Sep 19, 2024
Merged
Feat: Fix all deletion issues, add graceful shutdown to everything, new delete confirmation process #3024
andrasbacsai
merged 99 commits into
coollabsio:next
from
peaklabs-dev:fix-#2546-deletion-issues
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build pack containers
peaklabs-dev
changed the title
[WIP] Fixes deletion issues
[WIP] Fixes all deletion issues and adds graceful shutdown
Aug 9, 2024
This reverts commit b5360e5.
peaklabs-dev
changed the title
[WIP] Feat: Fix all deletion issues, add graceful shutdown to everything and add 2 step delete confirmation
Feat: Fix all deletion issues, add graceful shutdown to everything, new delete confirmation process
Sep 5, 2024
ETA to release? thanks |
Just waiting on @andrasbacsai to approve and check this. |
andrasbacsai
approved these changes
Sep 19, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2546
Fixes: #2726
Fixes: #2235
Fixes: #1352
Fixes: #3195
Fixes: https://discord.com/channels/459365938081431553/1271391857485811752
Add: #1814
1 confirmation (enter ressource Name/domain):
2 confirmation (user password):