Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fix all deletion issues, add graceful shutdown to everything, new delete confirmation process #3024

Merged
merged 99 commits into from
Sep 19, 2024

Conversation

peaklabs-dev
Copy link
Member

@peaklabs-dev peaklabs-dev commented Aug 7, 2024

Fixes: #2546
Fixes: #2726
Fixes: #2235
Fixes: #1352
Fixes: #3195
Fixes: https://discord.com/channels/459365938081431553/1271391857485811752
Add: #1814


  • Fix: Stopping large amounts of containers (for example Appwrite, 21 Containers) would fail in some cases and then they would not be deleted properly form the server (not properly stopped at all): https://discord.com/channels/459365938081431553/1271391857485811752
  • Fix: Add longer timeout (300s) wiche should be more then enough for larger amounts of containers (custom kill timeout is not needed because of this and the fix above)
  • Fix: Network deletion of services and applications after their deletion
  • Fix: Unused image deletion after services and application deletion
  • Fix: database, services and application containers, networks, unused images are properly deletion on stop
  • Fix: Cleanup unused images after deleting a database
  • Fix: Cleanup unused images on all applications, not only compose based applications
  • Feat: Setting to enable/ disabel network deletion and docker cleanup:
image
  • Feat: Add a 2-step delete confirmation to critical delete actions, so things are not deleted by accident and the delete action is verified that it actually comes from an authorized user. This process is used by big companies like Github and Hetzner, so I added it to coolify as well.
    1 confirmation (enter ressource Name/domain):
image

2 confirmation (user password):
image

  • Feat: Refactored all confirmations to use either 0, 1 or 2 step confirmation according to 3 risk levels:
  1. Low Risk (click confirm): Cleanup ...
  2. Medium risk (confirm with name - 1 step verification): Preview deployment deletion, project deletion...
  3. High risk (confirm with name and with user password - 2 Step verification): Ressource deletion, user deletion ...
  • Feat: Detailed description of everything that could have consequences.
  • Feat: Graceful Service containers stop (tries gracefully first, otherwise kills the containers)
  • Feat: Graceful Application stop (tries gracefully first, otherwise kills the containers)
  • Feat: Graceful Database stop (tries gracefully first, otherwise kills the containers)
  • Feat: Graceful Coolify Proxy stopping (tries gracefully first, otherwise kills the containers)
  • Feat: Graceful stopping for preview deployments (tries gracefully first, otherwise kills the containers)
  • Improvement: graceful_shutdown_container container kills the container if it wont shut down
  • Feat: Ability to delete all backups of a database backup job at once (checkbox)
  • Feat: If the backup job is the last one and backup deletion is enabled also delete the empty folder on the server
  • Improvements: A lot of other small tweaks around deletion and stopping... here and there.

@peaklabs-dev peaklabs-dev changed the title [WIP] Fixes deletion issues [WIP] Fixes all deletion issues and adds graceful shutdown Aug 9, 2024
@peaklabs-dev peaklabs-dev changed the title [WIP] Feat: Fix all deletion issues, add graceful shutdown to everything and add 2 step delete confirmation Feat: Fix all deletion issues, add graceful shutdown to everything, new delete confirmation process Sep 5, 2024
@peaklabs-dev peaklabs-dev marked this pull request as ready for review September 5, 2024 15:56
@markitosgv
Copy link

ETA to release? thanks

@peaklabs-dev
Copy link
Member Author

Just waiting on @andrasbacsai to approve and check this.

@coollabsio coollabsio deleted a comment from gitguardian bot Sep 19, 2024
@andrasbacsai andrasbacsai merged commit 4b02deb into coollabsio:next Sep 19, 2024
1 check passed
@peaklabs-dev peaklabs-dev deleted the fix-#2546-deletion-issues branch September 19, 2024 09:26
@peaklabs-dev peaklabs-dev mentioned this pull request Sep 19, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants