-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Improve backup retention (for database backups) #4818
Merged
andrasbacsai
merged 13 commits into
coollabsio:next
from
peaklabs-dev:feat-backup-retention
Jan 14, 2025
Merged
Feat: Improve backup retention (for database backups) #4818
andrasbacsai
merged 13 commits into
coollabsio:next
from
peaklabs-dev:feat-backup-retention
Jan 14, 2025
+425
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename number_of_backups_locally to database_backup_retention_amount_locally - add backup retention days to local stored backups - add s3 retention fields
- use the new removeOldBackups function - only call removeOldBackups function when the backup is completed and also only if the backup is successful
- fix: Delete folder and parent folder if folders are empty when deleting local backups. - fix: Do not remove executions from DB until both S3 and local backups have been deleted and successfully processed otherwise backups will never be deleted from s3. - fix: Server ID could be null
- feat: add storage retention to local storage as well - fix: UI input for max storage now allows exact decimals so MB input is now also possible - fix: Database column is now decimal instead of integer - fix: variable naming of storage check no longer overwrites $backup - renamed it to $backupExecution
peaklabs-dev
changed the title
Feat: Improves backup retention (for database backups)
Feat: Improve backup retention (for database backups)
Jan 13, 2025
Thank you for the PR! I love it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
removeOldBackups
function in theDatabaseBackupJob.php
if the backup is completed and successful, this caused problems before0
now means unlimited retention (so a value is now required for retention).number_of_backups_locally
todatabase_backup_retention_amount_locally
Note
Issues
/claim #4782