fix: do not cancel refused order when we cancel related tasks

coopcycle · Feb 6, 2025 · 725873e · 725873e
1 parent d5d3144
commit 725873e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/Doctrine/EventSubscriber/TaskSubscriber.php b/src/Doctrine/EventSubscriber/TaskSubscriber.php
@@ -224,6 +224,7 @@ private function handleStateChangesForTasks(EntitymanagerInterface $em, array $t
                     continue;
                 }
 
+                // if all tasks of a delivery are cancelled, cancel the linked order
                 $tasks = $delivery->getTasks();
                 $cancelOrder = true;
                 foreach ($tasks as $task) {
@@ -233,7 +234,8 @@ private function handleStateChangesForTasks(EntitymanagerInterface $em, array $t
                     }
                 }
 
-                if ($cancelOrder && $order->getState() !== OrderInterface::STATE_CANCELLED) {
+                // do not cancel order if order is "refused"
+                if ($cancelOrder && $order->getState() !== OrderInterface::STATE_CANCELLED && $order->getState() !== OrderInterface::STATE_REFUSED) {
                     $this->orderManager->cancel($order, 'All tasks were cancelled');
                     $em->flush();
                 }