Feat/barcode v2 #4732
Merged
Feat/barcode v2 #4732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the behavior of the endpoint if the task is linked to a delivery. Instead of only assigning the task in question, the entire delivery is assigned. This may be less compliant with REST principles, but leaving it as it was without any validation would have allowed clients to assign a delivery to different riders.
This change is related to the previous commit.
r0xsh
force-pushed
the
feat/barcode-v2
branch
from
c009298 to
3eb16e1
Compare
r0xsh
force-pushed
the
feat/barcode-v2
branch
from
e2068ae to
2498e92
Compare
r0xsh
force-pushed
the
feat/barcode-v2
branch
from
7e294fd to
9b0ab19
Compare
Atala
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
hello it seems good to me
can you check this bug and if it happens when you assign a delivery with a barcode? (drop is before pickup in the list) because I use the same functions as you
#4725
also there may be a UI/UX problem from:
- assign delivery1 with barcode
- assign delivery2 with barcode
then I think the rider will have the following assignments
- delivery1.pickup
- delivery1.dropoff
- delivery2.pickup
- delivery2.dropoff
but you may want to have all the pickups assigned first in the tasklist then the drops to be done afterwards
| @@ -76,25 +79,45 @@ public function barcodeAction( | |||
| * Possible actions: ask_to_assign, ask_to_unassign | |||
| * ask_to_assign: Will prompt the user to self-assign | |||
There was a problem hiding this comment.
shall we have ask_to_start in the workflow? or maybe assign the task + start the task?
There was a problem hiding this comment.
Yeah good idea ! But i'm expecting changes here. I'm pretty sure the auto-assign on scan can fire back on multi points delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Includes
assignTo(User)andunassign()methods to theDeliveryentity./api/tasks/:id/{un}assignEndpoints:{un}assignendpoints now apply to the entire delivery if the task is linked to one. Initially, I considered adding separate methods on theDeliveryentity endpoint, but decided against it to maintain data integrity directly via a single endpoint./api/barcodeEndpoint:To Be Completed
BarcodeControllermethods (consider using a Voter)