Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it possible to get notes or annotations of reactions and events? #53

Closed
pmendes opened this issue May 26, 2024 · 3 comments
Closed

Comments

@pmendes
Copy link
Member

pmendes commented May 26, 2024

I'm able to get notes for most model elements using get_notes() but this does not seem to work for reactions. For a reaction called 'R1' I tried with names such as 'R1', 'Reactions[R1]' , 'Reactions(R1)' or 'Reactions.R1' but none seem to work . I also tried passing element=el where el is the object retrieved with get_reaction(). The same happens to events. Is this not supported?

@fbergmann
Copy link
Member

it should have worked, with the name. As I just pass that to the C++ API and retrieve the object by display name. However, testing this right now this is not working. I'll release a new version that solves the issue.

fbergmann added a commit that referenced this issue May 26, 2024
even on elements that cannot be resolved by display name.
@fbergmann
Copy link
Member

I've released a new version that fixes the issue. So it should work like this:

notes = get_notes(name='r0')

where r0 is a reaction / event or anything really.

@pmendes
Copy link
Member Author

pmendes commented May 27, 2024

Thanks! You are a star!

@pmendes pmendes closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants