Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adapt meta.yml to v8.20 & Add dedicated CI test using coqorg/base #91

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Jun 19, 2024

No description provided.

@erikmd erikmd requested a review from proux01 June 19, 2024 21:39
@erikmd erikmd self-assigned this Jun 19, 2024
otherwise we get -> installed coq-bignums.8.20.dev
@erikmd erikmd assigned proux01 and unassigned erikmd Jun 19, 2024
@erikmd
Copy link
Member Author

erikmd commented Jun 19, 2024

@proux01 the CI is green with this new version of bignums' CI that doesn't require a docker-coq image with bignums

two questions:

  • this PR is ready from my viewpoint, feel free to merge it or squash it tomorrow Thursday if you can

  • next, before I can prepare an image of coqorg/coq:8.20-alpha with coq-bignums (continuously built from coq branch v8.20), is it OK that we release a new tag of bignums v9.0.0+coq8.20?
    or should we just add a version in extra-dev from the bignums branch v8.20 (which might be tricky w.r.t. the naming convention maybe)

@proux01
Copy link
Collaborator

proux01 commented Jun 20, 2024

Thanks @erikmd , yes feel free to go ahead with the tag, that's what we usually do for each Coq release.

@proux01 proux01 merged commit 1c47936 into v8.20 Jun 20, 2024
1 check passed
@proux01 proux01 deleted the ci/v8.20 branch June 20, 2024 06:58
@erikmd
Copy link
Member Author

erikmd commented Jun 20, 2024

just FYI @proux01 I ported the new CI workflow to the master branch: 379748e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants