Adapt w.r.t. coq/coq#16004. #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to make it backward compatible? |
|
Up to which version do you want it to be compatible? In theory the current patch should be compatible up to 8.14, I don't know why the CI failed. With a few tweaks it can be made compatible up to 8.11. |
|
All dependants of this library (per OPAM) currently develop on Coq >= 8.11, so it's fine to drop support to older Coq versions. |
ppedrot
force-pushed
the
hint-locality-error
branch
from
27022db to
1bada58
Compare
|
@liyishuai this should be backwards compatible up to 8.11 now. |
|
@liyishuai ping |
|
Cherry-picking 27022db should fix the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.