Add matrix normal forms #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I think merging this as close to verbatim from the other repo state as possible is a good idea, so we can track the evolution of the code. We could put specific improvements as tasks in issues. Or what do you think @proux01? |
Yes, for example, the companion matrix has been added to mathcomp already. |
CohenCyril
approved these changes
Oct 25, 2021
CohenCyril
requested changes
Oct 25, 2021
|
So I advocate merging after the release of mathcomp and other packages no to mess with the CI. |
|
I can update the |
|
I'll open a PR on nixpkgs |
12 tasks
|
Here it is: NixOS/nixpkgs#142858 |
This was referenced Oct 26, 2021
vbgl
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Nov 2, 2021
In order to include matrix normal forms in CoqEAL (coq-community/coqeal#54) we add a dependency to mathcomp-real-closed.
proux01
force-pushed
the
add-matrix-normal-forms
branch
from
c826a7a to
f837e55
Compare
|
OPAM and Nix packages have been updated, so I'm merging and I will release a 1.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #53.
From what I can tell from the diff, the file
similar.vis completely superseded by thesimilar.vfile here.